]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
popupMenu: Fix closing submenus when clicking on the expander
authorJasper St. Pierre <jstpierre@mecheye.net>
Mon, 15 Jul 2013 23:38:05 +0000 (19:38 -0400)
committerJasper St. Pierre <jstpierre@mecheye.net>
Wed, 17 Jul 2013 16:52:22 +0000 (12:52 -0400)
We need to make sure that we reset the opened submenu when we close the
submenu, not trick the toplevel into thinking a closed submenu is the
currently opened menu.

https://bugzilla.gnome.org/show_bug.cgi?id=704336

js/ui/popupMenu.js

index b8503bf762f6006c664114c4e9c66d7088a056f0..7aaecf52df69a3733a64ade2654dabf36d73b9ee 100644 (file)
@@ -1369,12 +1369,13 @@ const PopupSubMenuMenuItem = new Lang.Class({
     },
 
     _subMenuOpenStateChanged: function(menu, open) {
-        if (open)
+        if (open) {
             this.actor.add_style_pseudo_class('open');
-        else
+            this._getTopMenu()._setOpenedSubMenu(this.menu);
+        } else {
             this.actor.remove_style_pseudo_class('open');
-
-        this._getTopMenu()._setOpenedSubMenu(this.menu);
+            this._getTopMenu()._setOpenedSubMenu(null);
+        }
     },
 
     destroy: function() {